It is currently Mon Sep 15, 2014 11:25 pm

All times are UTC - 8 hours




Post new topic Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Support version suffix like "5.1.1-distro" in UBCD FreeDOS
PostPosted: Thu Aug 23, 2012 5:28 am 
Offline

Joined: Fri Jun 17, 2011 11:23 pm
Posts: 159
I want to update a few applications in UBCD FreeDOS and make a custom version for myself. And I wish to add some "version suffix" in order to distinguish my version with the official UBCD 5.1.1. (So my version will be something like "5.1.1-expl3".)

However the UBCD scripts doesn't seem to allow me to do so. So I make a feature request here.

Screenshot of what it will look like:
https://www.dropbox.com/s/vvflepv1w44kf ... suffix.png
Image

Actually I tried modifying the code to make the feature work for me.

Patch to "bin\ubcd.bat" inside "LEVEL3\AUTORUN3.CAB" in "<fdubcd-extracted>\fdubcd.img":
http://dl.dropbox.com/u/70170658/ubcd/u ... patch.diff
This allows me to change the Version field in <fdubcd-extracted>\dosapps\ubcd.ini to have a suffix, like this
Code:
Version = 5.1.1."expl3"
It will display like the screenshot above. (5.1.1expl3 , Dots and quotation marks are removed.)


Top
 Profile  
 
 Post subject: Re: Support version suffix like "5.1.1-distro" in UBCD FreeD
PostPosted: Thu Aug 23, 2012 7:23 am 
Offline

Joined: Sat May 08, 2010 5:26 am
Posts: 763
I haven't tried your patch yet, but I'd like to ask you anyway...

What exactly is not allowing you to add such custom "subversion" code in the original batch? I mean, is it a certain length? Or a certain character? Or what?


Top
 Profile  
 
 Post subject: Re: Support version suffix like "5.1.1-distro" in UBCD FreeD
PostPosted: Thu Aug 23, 2012 5:08 pm 
Offline

Joined: Fri Jun 17, 2011 11:23 pm
Posts: 159
ady wrote:
I haven't tried your patch yet, but I'd like to ask you anyway...

What exactly is not allowing you to add such custom "subversion" code in the original batch? I mean, is it a certain length? Or a certain character? Or what?


Yes, the custom "subversion" code was limited to 2 characters before my patch. If I set "Version = 5.1.1abc", the last letter c will be cut off.
(Line 118)
Code:
lmod [1,1].[2,1].[3,3]<%tmp%\_ubcd.tmp | nset ubcd_ver=$0


Also there's another line in the script that would not work if I add the "subversion" code:
(Line 328)
Code:
if "%ubcd_ver%"=="4.1.1" if "%lfn%"=="Y" call lfn -d

If I set "Version = 4.1.1b", the "call lfn -d" won't run.


Top
 Profile  
 
 Post subject: Re: Support version suffix like "5.1.1-distro" in UBCD FreeD
PostPosted: Sat Aug 25, 2012 12:52 am 
Offline

Joined: Sat May 08, 2010 5:26 am
Posts: 763
Generally speaking, there is a certain risk of breaking something else when changing seemingly non-essential / non-important little things. Let me explain.

The current DOS-based boot and menu system used in UBCD is not being maintained anymore by the original developers. So any changes made there, must be tested and reviewed in different situations, with different type of programs being booted and in different hardware, as it would be a customization in UBCD. Remember that the original system was made for several different DOSes too.

Let me give you an example (among many). You could try changing the "VOLUME_ID" value in several scripts. It is, seemingly, something that shouldn't be of any importance. But the same value is used in mkisofs for different fs (and each fs has different restrictions regarding this value), and it is also used in (Linux and/or Windows) scripts. So the value used in "VOLUME_ID" shall respond to different restrictions, but a common user might want to change this value without knowing about such restrictions. BTW, there are more than one "VOLUME_ID" variables in UBCD, and the most restricted case responds to 11 upper case characters.

There is one additional layer of scripts (not necessarily included in UBCD), that is used when building a new official release.

Now, going back to the particular case you present here, the only case when this needs to be altered would be, as you explained, when a user wants to have more than one fdubcd AND also wants each fdubcd to be identified differently in the specific fdubcd menu.

In most cases, the user would edit the same fdubcd so to customize it and re-build it (mkfdubcd scripts), leaving only one customized menu. For the fdubcd system included in each release, there is no need for more available characters for the VERSION setting, so the official releases don't really need this particular change.

Additionally, in some cases (although, a little different situation from your current one) the user would simply add a complete separated floppy image to run a custom DOS program instead of adding it to fdubcd.

Once in a while I am very tempted to customize the scripts in fdubcd with improvements (for example to have a different control over the booting process, depending on the specific DOS program to be started), but usually there is not enough feedback or testing, so I'm then discouraged.

Please don't misunderstand this post. When an update is convenient and practical (for example with new versions of DOS programs, like memory managers or drivers), changes shall be done. And sharing our own customizations is always welcomed, thanked, and useful for the improvement of UBCD. So please keep sharing them, and Victor might decide to use them in future UBCD releases.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC - 8 hours


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  

Protected by Anti-Spam ACP Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group